From ea36b2ba4b2d9efe52396adf9f766e1a29e1c20d Mon Sep 17 00:00:00 2001 From: NorkzYT Date: Sun, 22 Mar 2026 21:10:55 +0000 Subject: [PATCH] fix(preferences): unchecked pages_enabled checkboxes now persist correctly HTML checkboxes send no value when unchecked, so the fallback "|| \"on\"" always re-enabled popular/trending/search on save. Changed default to "off" to match the pattern used by captcha_enabled, login_enabled, and other checkbox toggles in the same handler. --- src/invidious/routes/preferences.cr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/invidious/routes/preferences.cr b/src/invidious/routes/preferences.cr index 1c4f4c9d..154f4637 100644 --- a/src/invidious/routes/preferences.cr +++ b/src/invidious/routes/preferences.cr @@ -202,9 +202,9 @@ module Invidious::Routes::PreferencesRoute CONFIG.default_user_preferences.feed_menu = admin_feed_menu CONFIG.pages_enabled = PagesEnabled.new( - popular: (env.params.body["popular_enabled"]?.try &.as(String) || "on") == "on", - trending: (env.params.body["trending_enabled"]?.try &.as(String) || "on") == "on", - search: (env.params.body["search_enabled"]?.try &.as(String) || "on") == "on", + popular: (env.params.body["popular_enabled"]?.try &.as(String) || "off") == "on", + trending: (env.params.body["trending_enabled"]?.try &.as(String) || "off") == "on", + search: (env.params.body["search_enabled"]?.try &.as(String) || "off") == "on", ) captcha_enabled = env.params.body["captcha_enabled"]?.try &.as(String)