VeritableValor/invidious
1
0
Fork 0
mirror of https://github.com/iv-org/invidious.git synced 2025-12-04 04:48:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

style: resolve code review suggestions

Browse Source
This commit is contained in:
Gus Libens 2025-11-13 19:54:21 +01:00
parent 670a4562d0
commit b83dbbaf2c
No known key found for this signature in database
GPG Key ID: 032E49D0FE9D51EA
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
assets/js/player.js
View File

@ -158,12 +158,7 @@ player.on('timeupdate', function () {
// Only update once every second // Only update once every second
let current_ts = Math.floor(player.currentTime()); let current_ts = Math.floor(player.currentTime());
const last_player_time = timeupdate_last_ts; const last_player_time = timeupdate_last_ts;
if ( if (current_ts !== timeupdate_last_ts) timeupdate_last_ts = current_ts;
// Seek forward
current_ts > timeupdate_last_ts ||
// Seek backward
current_ts < timeupdate_last_ts
) timeupdate_last_ts = current_ts;
else return; else return;
// YouTube links // YouTube links
@ -198,16 +193,16 @@ player.on('timeupdate', function () {
elem_iv_other.href = addCurrentTimeToURL(base_url_iv_other, domain); elem_iv_other.href = addCurrentTimeToURL(base_url_iv_other, domain);
} }
// Only increase time watched when the time difference is one second or the video is not already marked as watched // Only increase time watched when the time difference is one second and the video has not been marked as watched
const isOneSecondDifference = current_ts - last_player_time === 1; const isOneSecondDifference = current_ts - last_player_time === 1;
const exceedsMarkWatchedAfterDuration = time_watched > MARK_WATCHED_AFTER_DURATION; const exceedsMarkWatchedAfterDuration = time_watched > MARK_WATCHED_AFTER_DURATION;
const $markWatchedAfterDuration = document.getElementById(`${STORAGE_MARK_WATCHED_AFTER_DURATION}_pref`); const $markWatchedAfterDuration = document.getElementById(`${STORAGE_MARK_WATCHED_AFTER_DURATION}_pref`);
const markWatchedAfterDuration = $markWatchedAfterDuration.innerText === "true" ?? false; const markWatchedAfterDuration = $markWatchedAfterDuration?.innerText === "true";
if (!isOneSecondDifference || exceedsMarkWatchedAfterDuration || markWatchedAfterDuration === false) return; if (!isOneSecondDifference || exceedsMarkWatchedAfterDuration || markWatchedAfterDuration === false) return;
time_watched += 1 time_watched += 1;
// Check if time watched exceeds 30 seconds or the video is fully watched // Check if time watched exceeds 30 seconds or the video is fully watched
const absolute_video_duration = Math.floor(player.duration()); const absolute_video_duration = Math.floor(player.duration());
@ -232,7 +227,7 @@ player.on('timeupdate', function () {
id: video_id id: video_id
}); });
const url = `/watch_ajax?${params}` const url = `/watch_ajax?${params}`;
helpers.xhr('POST', url, { payload: `csrf_token=${csrf_token}` }, { helpers.xhr('POST', url, { payload: `csrf_token=${csrf_token}` }, {
on200: () => { on200: () => {