Fix Style/RedundantBegin type of Ameba issues

.ameba.yml

@@ -31,9 +31,6 @@ Lint/SpecFilename:
 # Style
 #
 
-Style/RedundantBegin:
-  Enabled: false
-
 Style/RedundantReturn:
   Enabled: false
 

src/invidious/user/preferences.cr

@@ -64,20 +64,18 @@ struct Preferences
     end
 
     def self.from_json(value : JSON::PullParser) : String
-      begin
+      result = value.read_string
-        result = value.read_string
 
-        if result.empty?
+      if result.empty?
-          CONFIG.default_user_preferences.dark_mode
+        CONFIG.default_user_preferences.dark_mode
-        else
+      else
-          result
+        result
-        end
+      end
-      rescue ex
+    rescue ex
-        if value.read_bool
+      if value.read_bool
-          "dark"
+        "dark"
-        else
+      else
-          "light"
+        "light"
-        end
       end
     end
 

src/invidious/user/user.cr

@@ -17,11 +17,9 @@ struct Invidious::User
 
   module PreferencesConverter
     def self.from_rs(rs)
-      begin
+      Preferences.from_json(rs.read(String))
-        Preferences.from_json(rs.read(String))
+    rescue ex
-      rescue ex
+      Preferences.from_json("{}")
-        Preferences.from_json("{}")
-      end
     end
   end
 end

src/invidious/yt_backend/extractors.cr

@@ -37,15 +37,13 @@ record AuthorFallback, name : String, id : String
 private module Parsers
   module BaseParser
     def parse(*args)
-      begin
+      return parse_internal(*args)
-        return parse_internal(*args)
+    rescue ex
-      rescue ex
+      LOGGER.debug("#{{{ @type.name }}}: Failed to render item.")
-        LOGGER.debug("#{{{ @type.name }}}: Failed to render item.")
+      LOGGER.debug("#{{{ @type.name }}}: Got exception: #{ex.message}")
-        LOGGER.debug("#{{{ @type.name }}}: Got exception: #{ex.message}")
+      ProblematicTimelineItem.new(
-        ProblematicTimelineItem.new(
+        parse_exception: ex
-          parse_exception: ex
+      )
-        )
-      end
     end
   end