VeritableValor/invidious
1
0
Fork 0
mirror of https://github.com/iv-org/invidious.git synced 2026-09-06 00:52:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(captions): rank human tracks before regional specificity

Browse Source 
Keep preference slot first, then human before auto-generated, and only
then use language specificity so an exact auto regional match cannot
beat a human base-language track.
This commit is contained in:
XZH 2026-09-05 00:41:45 -07:00
parent c4e2bc34c5
commit 7f990b061a
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/invidious/videos/captions_matching_spec.cr
View File

@ -51,6 +51,14 @@ Spectator.describe Invidious::Videos::Captions do
expect(matched.map(&.name)).to eq(["en-US", "en-GB"])
end
it "prefers human base-language English over exact regional auto-generated" do
human = Invidious::Videos::Captions::Metadata.new("English", "en", "http://x", false)
auto_us = Invidious::Videos::Captions::Metadata.new("en-US", "en-US", "http://x", true)
matched = Invidious::Videos::Captions.matching([auto_us, human], ["English (United States)"])
expect(matched.map(&.name)).to eq(["English", "en-US"])
end
it "ignores blank preference slots" do
arabic = Invidious::Videos::Captions::Metadata.new("Arabic (auto-generated)", "ar", "http://x", true)
matched = Invidious::Videos::Captions.matching([arabic], ["", "", ""])

5
src/invidious/videos/caption.cr
View File

@ -87,7 +87,8 @@ module Invidious::Videos
end
# Tracks whose name or language matches the user's caption preferences,
# ranked by preference slot then human tracks before auto-generated.
# ranked by preference slot, then human tracks before auto-generated,
# then more-specific language matches ahead of base-language fallbacks.
def self.matching(captions : Array(Metadata), names : Array(String)) : Array(Metadata)
wanted = names.map(&.strip).reject(&.empty?)
return [] of Metadata if wanted.empty?
@ -208,7 +209,7 @@ module Invidious::Videos
end
auto_rank = caption.auto_generated ? 1 : 0
{pref_rank, specificity, auto_rank}
{pref_rank, auto_rank, specificity}
end
# List of all caption languages available on Youtube.