From bece72210adc8ee9793d80ee004c8043d558848b Mon Sep 17 00:00:00 2001 From: Fijxu Date: Tue, 18 Nov 2025 12:55:31 -0300 Subject: [PATCH 1/2] Replace deprecated `blocking` property of `Socket` This replaces the deprecated argument `blocking` and uses `Socket.set_blocking(fd, value)` instead. Fixes a warning in the compiler https://github.com/crystal-lang/crystal/pull/16033 --- src/invidious/helpers/crystal_class_overrides.cr | 3 ++- src/invidious/helpers/sig_helper.cr | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/invidious/helpers/crystal_class_overrides.cr b/src/invidious/helpers/crystal_class_overrides.cr index fec3f62c..72a17255 100644 --- a/src/invidious/helpers/crystal_class_overrides.cr +++ b/src/invidious/helpers/crystal_class_overrides.cr @@ -5,7 +5,8 @@ class TCPSocket def initialize(host, port, dns_timeout = nil, connect_timeout = nil, blocking = false, family = Socket::Family::UNSPEC) Addrinfo.tcp(host, port, timeout: dns_timeout, family: family) do |addrinfo| - super(addrinfo.family, addrinfo.type, addrinfo.protocol, blocking) + super(addrinfo.family, addrinfo.type, addrinfo.protocol) + Socket.set_blocking(self.fd, blocking) connect(addrinfo, timeout: connect_timeout) do |error| close error diff --git a/src/invidious/helpers/sig_helper.cr b/src/invidious/helpers/sig_helper.cr index 6d198a42..e6f09a72 100644 --- a/src/invidious/helpers/sig_helper.cr +++ b/src/invidious/helpers/sig_helper.cr @@ -316,7 +316,7 @@ module Invidious::SigHelper {% end %} @socket.sync = false - @socket.blocking = false + Socket.set_blocking(@socket.fd, false) end def closed? : Bool From 11ae5721a7986968249bb2fb27484f7dd6b391c7 Mon Sep 17 00:00:00 2001 From: Fijxu Date: Sun, 30 Nov 2025 15:25:52 -0300 Subject: [PATCH 2/2] Upgrade to upstream --- src/invidious/helpers/crystal_class_overrides.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/invidious/helpers/crystal_class_overrides.cr b/src/invidious/helpers/crystal_class_overrides.cr index 72a17255..6da50628 100644 --- a/src/invidious/helpers/crystal_class_overrides.cr +++ b/src/invidious/helpers/crystal_class_overrides.cr @@ -3,9 +3,9 @@ # IPv6 addresses. # class TCPSocket - def initialize(host, port, dns_timeout = nil, connect_timeout = nil, blocking = false, family = Socket::Family::UNSPEC) + def initialize(host : String, port, dns_timeout = nil, connect_timeout = nil, blocking = false, family = Socket::Family::UNSPEC) Addrinfo.tcp(host, port, timeout: dns_timeout, family: family) do |addrinfo| - super(addrinfo.family, addrinfo.type, addrinfo.protocol) + super(family: addrinfo.family, type: addrinfo.type, protocol: addrinfo.protocol) Socket.set_blocking(self.fd, blocking) connect(addrinfo, timeout: connect_timeout) do |error| close