From 3a68d5aeb207538b9f815e3537489817ec9948fe Mon Sep 17 00:00:00 2001
From: Sijawusz Pur Rahnama <sija@sija.pl>
Date: Sun, 11 Jan 2026 22:35:01 +0100
Subject: [PATCH] Fix `Style/RedundantNilInControlExpression` type of Ameba
 issues

---
 src/invidious/videos.cr                      | 2 +-
 src/invidious/videos/parser.cr               | 6 +++---
 src/invidious/yt_backend/extractors_utils.cr | 2 +-
 src/invidious/yt_backend/url_sanitizer.cr    | 2 +-
 src/invidious/yt_backend/youtube_api.cr      | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/invidious/videos.cr b/src/invidious/videos.cr
index 228dce334..4f07f4bbd 100644
--- a/src/invidious/videos.cr
+++ b/src/invidious/videos.cr
@@ -149,7 +149,7 @@ struct Video
 
   def dash_manifest_url : String?
     raw_dash_url = info.dig?("streamingData", "dashManifestUrl").try &.as_s
-    return nil if raw_dash_url.nil?
+    return if raw_dash_url.nil?
 
     # Use manifest v5 parameter to reduce file size
     # See https://github.com/iv-org/invidious/issues/4186
diff --git a/src/invidious/videos/parser.cr b/src/invidious/videos/parser.cr
index 8114ad684..87974e686 100644
--- a/src/invidious/videos/parser.cr
+++ b/src/invidious/videos/parser.cr
@@ -7,7 +7,7 @@ require "json"
 # TODO: "compactRadioRenderer" (Mix) and
 # TODO: Use a proper struct/class instead of a hacky JSON object
 def parse_related_video(related : JSON::Any) : Hash(String, JSON::Any)?
-  return nil if !related["videoId"]?
+  return if !related["videoId"]?
 
   # The compact renderer has video length in seconds, where the end
   # screen rendered has a full text version ("42:40")
@@ -57,7 +57,7 @@ def extract_video_info(video_id : String)
   player_response = YoutubeAPI.player(video_id: video_id)
 
   if player_response.nil?
-    return nil
+    return
   end
 
   playability_status = player_response.dig?("playabilityStatus", "status").try &.as_s
@@ -147,7 +147,7 @@ def try_fetch_streaming_data(id : String, client_config : YoutubeAPI::ClientConf
   elsif playability_status == "OK"
     return response
   else
-    return nil
+    return
   end
 end
 
diff --git a/src/invidious/yt_backend/extractors_utils.cr b/src/invidious/yt_backend/extractors_utils.cr
index c83a2de5a..21c958ace 100644
--- a/src/invidious/yt_backend/extractors_utils.cr
+++ b/src/invidious/yt_backend/extractors_utils.cr
@@ -17,7 +17,7 @@
 # another nil will be returned.
 def extract_text(item : JSON::Any?) : String?
   if item.nil?
-    return nil
+    return
   end
 
   if text_container = item["simpleText"]?
diff --git a/src/invidious/yt_backend/url_sanitizer.cr b/src/invidious/yt_backend/url_sanitizer.cr
index d539dadbb..856a18d68 100644
--- a/src/invidious/yt_backend/url_sanitizer.cr
+++ b/src/invidious/yt_backend/url_sanitizer.cr
@@ -46,7 +46,7 @@ module UrlSanitizer
     when "results", "search"
       return :search
     else # hashtag, post, trending, brand URLs, etc..
-      return nil
+      return
     end
   end
 
diff --git a/src/invidious/yt_backend/youtube_api.cr b/src/invidious/yt_backend/youtube_api.cr
index 5fd08b274..fcee06040 100644
--- a/src/invidious/yt_backend/youtube_api.cr
+++ b/src/invidious/yt_backend/youtube_api.cr
@@ -463,7 +463,7 @@ module YoutubeAPI
     if CONFIG.invidious_companion.present?
       return _post_invidious_companion("/youtubei/v1/player", data)
     else
-      return nil
+      return
     end
   end